Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify save buttons in stats #3747

Merged
merged 2 commits into from Jul 12, 2023
Merged

Unify save buttons in stats #3747

merged 2 commits into from Jul 12, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3722

@CarolineDenis CarolineDenis requested review from melton-jason and a team July 7, 2023 16:58
@melton-jason
Copy link
Contributor

melton-jason commented Jul 7, 2023 •
edited

@specify/ux-testing
How about the footer buttons (Clone, Close, Save) in the Stats Query Dialog? Should these be consistent with other buttons as well?
The Clone and Save buttons are currently Info buttons.

Screenshot_2023-07-07_13-33-35

@grantfitzsimmons grantfitzsimmons linked an issue Jul 12, 2023 that may be closed by this pull request
Apply button color preferences to statistics page save button #3722
Closed
@grantfitzsimmons
Copy link
Contributor

@carlosmbe @bronwyncombs Please test this soon

@bronwyncombs
Copy link

@carlosmbe @bronwyncombs Please test this soon

I didn't think we could until @melton-jason has a ✔️

@CarolineDenis
Copy link
Contributor Author

@carlosmbe @bronwyncombs Please test this soon

I didn't think we could until @melton-jason has a ✔️

@bronwyncombs you're correct :) this is a little exception sorry

bronwyncombs
bronwyncombs approved these changes Jul 12, 2023
View reviewed changes
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save buttons in stats page are now synced with Save button color chosen in preferences.

Edit Page and main save:
Screenshot 2023-07-12 at 11 36 12 AM

Other areas confirmed on stats:

  • Add page save
  • Add new stat save

melton-jason
melton-jason approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the buttons are consistent in the UI throughout StatsPage, then this is good now 😁

@CarolineDenis CarolineDenis merged commit 7e59bd8 into v7.9-dev Jul 12, 2023
8 of 9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3722 branch July 12, 2023 17:25
@grantfitzsimmons grantfitzsimmons mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melton-jason melton-jason melton-jason approved these changes

@bronwyncombs bronwyncombs bronwyncombs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply button color preferences to statistics page save button
4 participants
@CarolineDenis @melton-jason @grantfitzsimmons @bronwyncombs