Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack-bundle visualizer option #3119

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Add webpack-bundle visualizer option #3119

merged 1 commit into from
Mar 8, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixed #2610

@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team March 8, 2023 15:41
@maxpatiiuk
Copy link
Member

maxpatiiuk commented Mar 8, 2023

The visualization looks super cool!
@specify/dev-testing @grantfitzsimmons I am going to merge this, but I encourage you to take a look at this as it's quite neat.

Really interesting that even though we use very few libraries, most of the bundle size is still comping from libraries (I added a red line around our code):

Screenshot 2023-03-08 at 10 53 28

The giant purple block at the top is handsontable (workbench spreadsheet library)
The big pink block at the top is for xlsx parsing
Thus, half of all shipped code is just 2 WB libraries!
The green is the main bundle - get's loaded before any page is displayed. Half of it is comprised of libraries, other half of our code
And then the small bundles at the bottom right are lazy-loaded for individual components (i.e, Security Page, Tree Viewer, Wb Import)

@maxpatiiuk maxpatiiuk merged commit daf753c into production Mar 8, 2023
@maxpatiiuk maxpatiiuk deleted the issue-2610 branch March 8, 2023 17:00
@grantfitzsimmons
Copy link
Member

That's so cool!

@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-8-release-announcement/1108/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webpack bundle visualizer to pull requests
4 participants