Rename Security and Accounts Create Button

[CarolineDenis]

Fixes #3716

[maxpatiiuk]

Looks good to me, but let's have Grant or any other user-facing person check this

[grantfitzsimmons]

Be warned, whatever the outcome from this, you must update this documentation:

https://discourse.specifysoftware.org/t/security-and-accounts/539

@carlosmbe as the requestor, I humbly request that you update this with the final decision once this is merged.

[grantfitzsimmons]

I have asked @bronwyncombs to select the labels that she thinks are the most intuitive and clear for the user. I will review them once they have been implemented.

We need to be consistent throughout all areas, so we should not interchangeably use Create and Add. I will review later!

[bronwyncombs]

I think that the buttons for User Roles are good as is for both Institution and Collections.

I think we should change the Create button below "User Accounts Assigned to this Collection" to say Assign User or something similar instead.

That would be one version of "consistent" by keeping buttons labeled Create in the Institution section. Another option would be to change both Create buttons below the User Accounts sections to Assign or Assign User. I believe I prefer the former to clearly differentiate Institution and Collection, but both options make sense.

Screen.Recording.2023-07-17.at.10.20.10.AM.mov

[carlosmbe]

Can someone ping or slack me when this is merged so I can update the documentation.

[bronwyncombs]

For the Add Role dialog, can the headers be different for Institution and Collection? I'd like to see the Institution Role dialog say "Add Role to Institution". If that is a complicated change, I think we should just have it read "Add Role".

Current Add Role dialog for Institution:

---

Everything else is great!!!

Institution Buttons

Collection Buttons

[bronwyncombs]

Looks good! 😄

[grantfitzsimmons]

Looks like we could remove addRoleToCollection and then merge if it is not being used