Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the statistics page buttons consistent with buttons elsewhere in the application #4315

Merged
merged 3 commits into from Dec 22, 2023
Merged

Make the statistics page buttons consistent with buttons elsewhere in the application #4315

merged 3 commits into from Dec 22, 2023

Conversation

grantfitzsimmons
Copy link
Contributor

Fixes #4314

@grantfitzsimmons grantfitzsimmons changed the base branch from production to batch-image-upload December 21, 2023 00:58
@grantfitzsimmons @github-actions
Lint code with ESLint and Prettier
18be398 
Triggered by c9c6217 on branch refs/heads/issue-4314
@grantfitzsimmons grantfitzsimmons changed the base branch from batch-image-upload to production December 21, 2023 01:07
@grantfitzsimmons grantfitzsimmons changed the base branch from production to batch-image-upload December 21, 2023 01:07
maxpatiiuk
maxpatiiuk approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the idea of Grant being a dev!

@grantfitzsimmons grantfitzsimmons requested a review from a team December 21, 2023 19:39
emenslin
emenslin approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons now have a border and the add button no longer has a background, I think this looks a lot cleaner.
Screenshot 2023-12-21 140231

realVinayak
realVinayak approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@realVinayak realVinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌋

@grantfitzsimmons grantfitzsimmons merged commit 825edf1 into batch-image-upload Dec 22, 2023
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-4314 branch December 22, 2023 03:45
@melton-jason melton-jason added this to the 7.9.3 milestone Jan 15, 2024
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-3-release-announcement/1499/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@realVinayak realVinayak realVinayak approved these changes

@emenslin emenslin emenslin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.3
Development

Successfully merging this pull request may close these issues.

Make the statistics page buttons consistent with buttons elsewhere in the application
6 participants
@grantfitzsimmons @specifysoftware @maxpatiiuk @realVinayak @emenslin @melton-jason