Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks #6

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Conversation

Zvirovyi
Copy link
Contributor

No description provided.

Copy link
Owner

@specinfo-ua specinfo-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commit ff5e34670f5bd1c2df0a98e4618dfeea924f3289. Memory free after cleanup label

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Zvirovyi
Copy link
Contributor Author

Okay, I have added new commit that fixes this issue.

But I must admit, that string(...) function does not free memory, and when you set this variable to null, you do have memory leak.

Example:

decodedEncapContentInfo.contentType = string(s_contype);
s_contype = nullptr;

will do memory leak.

@specinfo-ua specinfo-ua merged commit cfd5c59 into specinfo-ua:main Jan 26, 2024
1 check failed
@Zvirovyi Zvirovyi deleted the fix-memory-leaks branch January 29, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants