Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileimport-service): write valid messages from underlying parsers #1969

Merged
merged 20 commits into from
Jan 16, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jan 12, 2024

Description & motivation

The file import service was not producing logs in clef format when wrapping the logs generated by underlying parsers.

This improves the handling of log messages to support CLEF.

Changes:

To-do before merge:

  • ensure {message} (see red highlight in screenshot) is being properly interpolated.

Screenshots:

Validation of changes:

Screenshot 2024-01-15 at 12 03 13

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review January 12, 2024 22:08
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1406465) 68.53% compared to head (44b5235) 68.53%.
Report is 2 commits behind head on main.

❗ Current head 44b5235 differs from pull request most recent head 1adc561. Consider uploading reports for the commit 1adc561 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1969   +/-   ##
=======================================
  Coverage   68.53%   68.53%           
=======================================
  Files         213      213           
  Lines        8107     8107           
  Branches      946      946           
=======================================
  Hits         5556     5556           
  Misses       2288     2288           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gjedlicska
gjedlicska previously approved these changes Jan 16, 2024
@iainsproat iainsproat merged commit ceeb30e into main Jan 16, 2024
19 of 21 checks passed
@iainsproat iainsproat deleted the iain/fileimport-service-clef-logging branch January 16, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants