Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Rhino): include standard views viewport in Project Info when sending #2118

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

Mehdi-Lucas
Copy link
Contributor

@Mehdi-Lucas Mehdi-Lucas commented Feb 6, 2023

Description & motivation

Allow Rhino standard views (viewport) to be included in the send operation.

This wasn’t possible before and a request was made on the community forum about it: https://speckle.community/t/send-the-views-from-reno-grasshopper-to-the-web-version/2109/6
The associated issue : #919

Changes:

Rhino Connector

To-do before merge:

Ensure the team is ok with this logic:

  • The Named View use their Name property as Id as they don’t have an associated guid. However the standard view viewport do have a guid and this was used as an Id to follow the rest of the object logic.

  • One should keep in my mind that when receiving standard views, they will be converted to Named Views in Rhino. Since the issue is only about sending, I only dealt with that.

Screenshots:

Standard appearing in the view tab and in their own "Standard views" container:
image

Validation of changes:

Test have been manually done in Rhino 7 and Rhino 6. This public stream contains standard views for exemple :

https://speckle.xyz/streams/5827632392/commits/eb333113b8

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clairekuang clairekuang merged commit 00d9f20 into specklesystems:release/2.12 Feb 7, 2023
@clairekuang clairekuang added rhino enhancement New feature or request labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external rhino
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants