Feat(Rhino): include standard views viewport in Project Info when sending #2118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Allow Rhino standard views (viewport) to be included in the send operation.
This wasn’t possible before and a request was made on the community forum about it: https://speckle.community/t/send-the-views-from-reno-grasshopper-to-the-web-version/2109/6
The associated issue : #919
Changes:
Rhino Connector
To-do before merge:
Ensure the team is ok with this logic:
The Named View use their Name property as Id as they don’t have an associated guid. However the standard view viewport do have a guid and this was used as an Id to follow the rest of the object logic.
One should keep in my mind that when receiving standard views, they will be converted to Named Views in Rhino. Since the issue is only about sending, I only dealt with that.
Screenshots:
Standard appearing in the view tab and in their own "Standard views" container:
Validation of changes:
Test have been manually done in Rhino 7 and Rhino 6. This public stream contains standard views for exemple :
https://speckle.xyz/streams/5827632392/commits/eb333113b8
Checklist: