Feat(Core) : Remove account from db and save new one #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2024 19:04
BovineOx
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
I think it is fine but would like @AlanRynne or @JR-Morgan to cast an eye before merging through
| s_accountStorage.UpdateObject(account.id!, JsonConvert.SerializeObject(account)); | ||
| RemoveAccount(id); | ||
| s_accountStorage.SaveObject(account.id, JsonConvert.SerializeObject(account)); | ||
| await s_accountStorage.WriteComplete().ConfigureAwait(false); |
There was a problem hiding this comment.
Seems fine, just unsure about this change to async and why WriteComplete() is necessary, seems a bit janky to me, but that's probably more about the storage?
JR-Morgan
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Because the account id is changing, we no longer need to update the object. Instead, we delete the old object from the db and then save a new one.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References