Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send receive reports #3448

Merged
merged 33 commits into from
Jun 6, 2024
Merged

Send receive reports #3448

merged 33 commits into from
Jun 6, 2024

Conversation

oguzhankoral
Copy link
Member

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

JR-Morgan and others added 22 commits May 23, 2024 21:34
@JR-Morgan
Conversion Results
db2ee0c
@JR-Morgan
Rhino
0f0371d
@JR-Morgan
ReceiveConversionResult
c7965fd
@JR-Morgan
Fixed highlighting
d62d6c6
@JR-Morgan
Moved result out of core
c512c9e
@JR-Morgan
SendConversionResult
d0b30b6
@oguzhankoral
Send error message instead all serialized exception
0eb2837
@oguzhankoral
Align conversion results with UI report
f3f831b
@oguzhankoral
Highlight object on Rhino
e1f6f66
@oguzhankoral
Merge remote-tracking branch 'origin/dui3/alpha' into jrm/rootObjectB…
19f4cd4 
…uilder

# Conflicts:
#	DUI3-DX/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Send/RevitRootObjectBuilder.cs
#	DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Bindings/RhinoReceiveBinding.cs
#	DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Operations/Send/RhinoRootObjectBuilder.cs
@oguzhankoral
Throw inner exception for highlight object
0592819
@oguzhankoral
Highlight sub elements of group in Rhino
8a7e2c5
@oguzhankoral
WIP
1ebc7f7
@JR-Morgan
Arcgis Receive Reporting
eee39b2
@JR-Morgan
split
2bbcca6
@oguzhankoral
Acad highlight objects method
db1cb31
@oguzhankoral
Revit highlight objects method
a140bad
@oguzhankoral
Arcgis highlight objects method
e127183
@oguzhankoral
Merge remote-tracking branch 'origin/dui3/alpha' into jrm/rootObjectB…
6a99f3f 
…uilder

# Conflicts:
#	DUI3-DX/Connectors/ArcGIS/Speckle.Connectors.ArcGIS3/Operations/Receive/HostObjectBuilder.cs
#	DUI3-DX/Connectors/Revit/Speckle.Connectors.RevitShared/Bindings/BasicConnectorBindingRevit.cs
@oguzhankoral
Merge branch 'dui3/alpha' into jrm/rootObjectBuilder
33db214
@oguzhankoral
Have public setters for deserialization
f63f8a6
@oguzhankoral
Merge branch 'dui3/alpha' into jrm/rootObjectBuilder
71e6a55
@oguzhankoral oguzhankoral marked this pull request as ready for review May 30, 2024 14:54
@didimitrie didimitrie mentioned this pull request May 30, 2024
Merged
@didimitrie
Copy link
Member

linked with specklesystems/speckle-server#2288

@didimitrie didimitrie self-assigned this May 30, 2024
@JR-Morgan JR-Morgan mentioned this pull request Jun 3, 2024
Closed
didimitrie
didimitrie approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, 👍

@oguzhankoral oguzhankoral merged commit 406e1e2 into dui3/alpha Jun 6, 2024
33 checks passed
@oguzhankoral oguzhankoral deleted the jrm/rootObjectBuilder branch June 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didimitrie didimitrie didimitrie approved these changes

@AlanRynne AlanRynne Awaiting requested review from AlanRynne

Assignees

@didimitrie didimitrie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oguzhankoral @didimitrie @JR-Morgan @KatKatKateryna