Fix EXC_BAD_ACCESS from copying block after the matcher is freed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakewatters
added a commit
that referenced
this pull request
Jul 25, 2013
Fix EXC_BAD_ACCESS from copying block after the matcher is freed
|
Looks good, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to 0.2.2, I ran into some
EXC_BAD_ACCESSerrors in -applyMatcher:to:. My theory was that the matcher got prematurely freed somewhere.Within
_EXPMatcherImplementationEnd, the matcher is freed before the block gets a chance to retain it (since blocks only retain captured objects when copied). Moving the block copy earlier than the release seems to fix the issue.