gRPC diagrams #1712
Merged
gRPC diagrams #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-cardenas-coding
added
backport-version-4-0
karl-cardenas-coding
requested review from
lennessyy,
caroldelwing and
ritawatson
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ritawatson
approved these changes
Oct 26, 2023
| @@ -182,12 +200,22 @@ The following ports must be reachable from a network perspective for Palette sel | |||
| |NATS (tcp/4222) |OUTBOUND |Agent communication via message bus | | |||
| |HTTPS (tcp/443) |OUTBOUND |vSphere vCenter API, Registry (packs, integrations), Pack containers, Application updates. | |||
There was a problem hiding this comment.
Suggested change
| |HTTPS (tcp/443) |OUTBOUND |vSphere vCenter API, Registry (packs, integrations), Pack containers, Application updates. | |
| |HTTPS (tcp/443) |OUTBOUND |vSphere vCenter API, Registry (packs, integrations), Pack containers, Application updates |
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* docs: fixed missing grpc images * docs: updated tabs order * Apply suggestions from code review Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> --------- Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> (cherry picked from commit fe87664)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 26, 2023
* docs: fixed missing grpc images * docs: updated tabs order * Apply suggestions from code review Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> --------- Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> (cherry picked from commit fe87664) Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding
added a commit
that referenced
this pull request
Oct 26, 2023
* docs: fixed missing grpc images * docs: updated tabs order * Apply suggestions from code review Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com> --------- Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR adds the missing gRPC images reported in the #docs channel by @JPedro2. A quick fix to the release notes is also added. The architecture page's structure has also been changed. Instead of a single tab group that displays the gRPC or the NATS architecture. Each section now contains its own tab to help the reader follow along easier.
Review Changes
💻 Preview URL