Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference interface uncompatible with Python < 3.9 #2452

Closed
lucadellalib opened this issue Mar 5, 2024 · 1 comment · Fixed by #2454
Closed

Inference interface uncompatible with Python < 3.9 #2452

lucadellalib opened this issue Mar 5, 2024 · 1 comment · Fixed by #2454
Labels
bug Something isn't working important

Comments

@lucadellalib
Copy link
Collaborator

Describe the bug

The new inference interface is not compatible with python<3.9. However in setup.py, we support python>=3.7. Python 3.8 is probably still one of the most used versions of Python.

Expected behaviour

Inference interface working for python>=3.7.

To Reproduce

>>> from speechbrain import inference
File ".../lib/python3.8/site-packages/speechbrain/inference/ASR.py", line 790, in StreamingASR
    ) -> tuple[list, list]:
TypeError: 'type' object is not subscriptable

Environment Details

No response

Relevant Log Output

No response

Additional Context

No response

@lucadellalib lucadellalib added bug Something isn't working important labels Mar 5, 2024
@asumagic
Copy link
Collaborator

"Fixed" by #2456, but if we actually want to keep support for Python 3.8 we should actually just support it again officially and update the CI tests for it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants