-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support & test Python 3.8-3.12 instead of 3.9-3.11 + bump CI pins #2454
Conversation
5017808
to
8a33374
Compare
I think this is a good change, it's good to test all the versions that we support if possible. My main concern is that it may close to double our CI minutes usage each month, is this something we have the capacity for or will it cause us to run out during the month @mravanelli ? |
One alternative could be to test 3.8, 3.10, 3.12 |
Reduces the risk of hitting into GitHub free CI limits
Ah, yeah, sorry, I hadn't noticed the notification on this PR. I've changed the tested versions to 3.8 and 3.12 if you think that makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change!
What does this PR do?
#2452 warns that a lot of stuff still seems to rely on Python 3.8. We have informally been fixing some issues with this version so we might as well make it a proper tested target instead of relying on reports. Thus:
setup.py
as that should probably have been updated a while agoPython 3.12 has decent support across the board (as far as I can tell, k2, PyTorch and Numba support it nowadays). Thus:
1.15
not available for Python 3.12 apparently)Before submitting
PR review
Reviewer checklist