Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support & test Python 3.8-3.12 instead of 3.9-3.11 + bump CI pins #2454

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

asumagic
Copy link
Collaborator

@asumagic asumagic commented Mar 7, 2024

What does this PR do?

#2452 warns that a lot of stuff still seems to rely on Python 3.8. We have informally been fixing some issues with this version so we might as well make it a proper tested target instead of relying on reports. Thus:

  • Add 3.8 to the test matrix in CI
  • Add 3.8 back as an officially supported version, but deprecate it
  • Bump from Python 3.7 to 3.8 in setup.py as that should probably have been updated a while ago

Python 3.12 has decent support across the board (as far as I can tell, k2, PyTorch and Numba support it nowadays). Thus:

  • Add 3.12 to the test matrix in CI
  • Add 3.12 as an officially supported version
  • Bump the pinned k2 version in CI along the way
  • Bump the pinned kaldilm version (1.15 not available for Python 3.12 apparently)
Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@asumagic asumagic marked this pull request as ready for review March 7, 2024 12:23
@asumagic asumagic marked this pull request as draft March 27, 2024 09:33
@asumagic asumagic changed the title Add Python 3.12 CI + bump CI versions + bump advertized max Python version support & test Python 3.8-3.12 instead of 3.9-3.11 + bump CI pins Mar 27, 2024
@asumagic asumagic marked this pull request as ready for review March 27, 2024 09:53
@asumagic asumagic linked an issue Mar 27, 2024 that may be closed by this pull request
@pplantinga
Copy link
Collaborator

I think this is a good change, it's good to test all the versions that we support if possible. My main concern is that it may close to double our CI minutes usage each month, is this something we have the capacity for or will it cause us to run out during the month @mravanelli ?

@pplantinga
Copy link
Collaborator

One alternative could be to test 3.8, 3.10, 3.12

@asumagic
Copy link
Collaborator Author

asumagic commented Apr 2, 2024

Ah, yeah, sorry, I hadn't noticed the notification on this PR. I've changed the tested versions to 3.8 and 3.12 if you think that makes sense.

Copy link
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@pplantinga pplantinga merged commit 605278b into speechbrain:develop Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inference interface uncompatible with Python < 3.9
2 participants