Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml #101

Merged
merged 2 commits into from
May 20, 2020
Merged

Update yaml #101

merged 2 commits into from
May 20, 2020

Conversation

pplantinga
Copy link
Collaborator

@pplantinga pplantinga commented May 19, 2020

Updates in this PR:

  • Add !copy tag for copying objects, rather than making a reference
  • Convert ! tag prefix to !new: and add !name: and !module:
  • Add !tuple tag for tuples, plus an implicit resolver if a string starts+ends with ()
  • Perform simple arithmetic on !ref and !copy nodes for stuff like filter sizes based on block #.
  • Remove merge op, anchors, and aliases from speechbrain yaml files.

@pplantinga pplantinga requested a review from Gastron May 19, 2020 22:03
@pplantinga pplantinga self-assigned this May 19, 2020
@pplantinga pplantinga added enhancement New feature or request ready to review Waiting on reviewer to provide feedback refactor Edit code without changing functionality labels May 19, 2020
@pplantinga pplantinga mentioned this pull request May 19, 2020
Copy link
Collaborator

@Gastron Gastron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I endorse these changes. We've had a lot of YAML discussion the past two days and this is what I think we converged to.

Code looks good to me. Props for the neat arithmetic implementation!

@pplantinga pplantinga merged commit b347dac into master May 20, 2020
@pplantinga pplantinga deleted the yaml-upgrades branch May 20, 2020 03:43
@pplantinga pplantinga mentioned this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to review Waiting on reviewer to provide feedback refactor Edit code without changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants