Fix bug where speechbrain would request files from HF even with local files provided #1254
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files provided Signed-off-by: Gabriel Ziegler <gabrielziegler3@gmail.com>
|
I believe that this change alone doesn't fix the whole issue, but the lines I changed were the one making |
|
What do you think of this PR @Gastron? |
8 tasks
|
Up @Gastron, could you please have a look ? |
|
Ooh this is an old PR, has somehow slipped past me, thanks for bringing it up again. |
Gastron
reviewed
Jan 18, 2024
There was a problem hiding this comment.
This changes the if/else logic, and would unfortunately break the case where default_source is not specified.
It seems to me that this PR just stems from path specification that did not work. I wonder if it is a path like "./filename.ckpt", perhaps that is currently broken?
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1253 Signed-off-by: Gabriel Ziegler gabrielziegler3@gmail.com