-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing of audio fetching from inference interface #1268
Conversation
This was added intentionally. Instead, the file methods in the Pretrained interfaces should take the savedir option. |
@Gastron is preventing fetching (and generating symlinks) if |
Perhaps we could instead finally change the fetch behaviour. This has been requested for other reasons, as well, e.g. issue #1055. We could instead do the following:
|
Hi, how this PR is going? I would be happy to contribute some changes if you need help. Those symlinks are a bit annoying for me so I would love to get rid of them soon :) |
I am not sure how to tackle the third point from @Gastron answer. If I'm not mistaken to solve the problem of unwanted symlinks, we could simply do elif pathlib.Path(source).is_dir():
destination = pathlib.Path(source) / filename in fetch and also we could add |
Hello, Any news with this PR please? Thanks. |
Dear @stachu86, Thank you for your contribution to our project through this pull request. Unfortunately, we have decided to close this pull request due to its staleness. Since the initial submission, our project has undergone significant updates, and we've released several new versions. As a result, we kindly request you to create a new pull request with the latest commits to ensure compatibility and integration with the current codebase. Please sync your fork with the latest changes from the main repository and address any potential conflicts that may arise during this process. We appreciate your understanding and continued interest in contributing to our project. If you have any questions or encounter difficulties while creating the new pull request, feel free to reach out. We value your contributions and look forward to seeing an updated pull request from you. Best regards, |
The method
load_audio()
usesfetch()
functionality, which (according to comments) is clearly intended to works with pretrained models, not audio files. This results in bloating working directory with symlinks to (local) audio files during classification, which I believe is a bug.If this was truly intended, ability to provide
savedir
shoud be included inspeechbrain.pretrained.interfaces.EncoderClassifier.classify_file()
instead of my proposed changes.