Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit for HF hub as it does not work with colab #1508

Merged
merged 1 commit into from Jul 19, 2022

Conversation

TParcollet
Copy link
Collaborator

Google colab is failing because HF hub bellow 0.7 is not managed properly due to some tensor flow version mismatch. We remove the maximum HF HUB version to avoid this

@pplantinga
Copy link
Collaborator

Could someone try the latest version of huggingface_hub with fetch()? We want to make sure nothing breaks here.

For reference, these are the relevant issues/PRs regarding the limit:

#1458 , #1459

@TParcollet
Copy link
Collaborator Author

I checked with the Profiler tutorial that downloads HF models. What is fetch referring to in your post?

@pplantinga
Copy link
Collaborator

The pretrained interfaces were my main concern. I tried it myself and it seems to work, so I'd say lets roll with this.

Copy link
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried pretrained model with huggingface_hub==0.8.1 and it works.

@pplantinga pplantinga merged commit 26e8907 into speechbrain:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants