Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length_normalization in Unstable Branch #2237

Merged
merged 1 commit into from Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -200,7 +200,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
modules: [!ref <Transformer>, !ref <seq_lin>]
Expand Down
Expand Up @@ -205,7 +205,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
modules: [!ref <Transformer>, !ref <seq_lin>]
Expand Down
Expand Up @@ -181,7 +181,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
modules: [!ref <Transformer>, !ref <seq_lin>]
Expand Down
Expand Up @@ -203,7 +203,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <valid_scorer>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -233,7 +233,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer_valid_search>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -225,7 +225,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -230,7 +230,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
modules: [!ref <Transformer>, !ref <seq_lin>]
Expand Down
Expand Up @@ -234,7 +234,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer_valid_search>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -235,7 +235,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer_valid_search>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -231,7 +231,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer_valid_search>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -232,7 +232,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer_valid_search>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -238,7 +238,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <valid_scorer>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
6 changes: 3 additions & 3 deletions recipes/LibriSpeech/G2P/hparams/hparams_g2p_transformer.yaml
Expand Up @@ -402,7 +402,7 @@ beam_searcher: !new:speechbrain.decoders.S2STransformerBeamSearcher
beam_size: !ref <beam_search_beam_size>
eos_threshold: !ref <beam_search_eos_threshold>
using_max_attn_shift: False
length_normalization: False
length_normalization: True
max_attn_shift: !ref <beam_search_max_attn_shift>
temperature: !ref <beam_search_temperature>
scorer: !ref <scorer>
Expand All @@ -416,7 +416,7 @@ beam_searcher_lm: !new:speechbrain.decoders.S2STransformerBeamSearcher
beam_size: !ref <beam_search_beam_size>
eos_threshold: !ref <beam_search_eos_threshold>
using_max_attn_shift: False
length_normalization: False
length_normalization: True
max_attn_shift: !ref <beam_search_max_attn_shift>
temperature: !ref <beam_search_temperature>
scorer: !ref <scorer_lm>
Expand All @@ -430,7 +430,7 @@ beam_searcher_valid: !new:speechbrain.decoders.S2STransformerBeamSearcher
beam_size: !ref <beam_search_beam_size_valid>
eos_threshold: !ref <beam_search_eos_threshold>
using_max_attn_shift: False
length_normalization: False
length_normalization: True
max_attn_shift: !ref <beam_search_max_attn_shift>
temperature: !ref <beam_search_temperature>
scorer: !ref <scorer_lm>
Expand Down
Expand Up @@ -218,7 +218,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: !ref <using_eos_threshold>
length_normalization: False
length_normalization: !ref <length_normalization>
using_max_attn_shift: !ref <using_max_attn_shift>
max_attn_shift: !ref <max_attn_shift>
scorer: !ref <scorer>
Expand Down
Expand Up @@ -212,7 +212,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
max_decode_ratio: !ref <max_decode_ratio>
beam_size: !ref <valid_beam_size>
using_eos_threshold: False
length_normalization: False
length_normalization: True
scorer: !ref <scorer>

test_search: !new:speechbrain.decoders.S2STransformerBeamSearcher
Expand Down
Expand Up @@ -181,7 +181,7 @@ valid_search: !new:speechbrain.decoders.S2STransformerBeamSearch
beam_size: !ref <valid_beam_size>
ctc_weight: !ref <ctc_weight_decode>
using_eos_threshold: False
length_normalization: False
length_normalization: True


test_search: !new:speechbrain.decoders.S2STransformerBeamSearch
Expand Down