Fix import statement ordering using isort #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pplantinga
requested review from
Gastron,
asumagic,
mravanelli and
Adel-Moumen
and removed request for
Gastron
asumagic
approved these changes
Apr 3, 2024
|
Hello @pplantinga, very nice PR! Thanks a lot. :) Do you mind updating your PR with the latest commits in the develop branch? Other than that, I think it is ready to be merged :) |
Closed
asumagic
added a commit
to asumagic/speechbrain
that referenced
this pull request
Apr 11, 2024
…dd-isort"" This reverts commit aaa856d.
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
isortto the linters. This is a nice way to ensure consistency and make imports easier to find.The initial version of this PR just uses the defaults from
isortbut if anyone has opinions there are other ways to sort.Default sorting is alphabetical within 3 sections:
There are options, such as sort by length, different sections etc. so if anyone wants a different sort, they should speak up.