Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests: SPDB-556 intoduced new err in customizable_test #27

Closed
Yuval-Ariel opened this issue Jun 23, 2022 · 2 comments · Fixed by #28
Closed

unit tests: SPDB-556 intoduced new err in customizable_test #27

Yuval-Ariel opened this issue Jun 23, 2022 · 2 comments · Fixed by #28
Assignees
@isaac-io
Labels
bug Something isn't working

Comments

@Yuval-Ariel
Copy link
Contributor

error:

[ RUN      ] CustomizableTest.PrepareOptionsTest
options/customizable_test.cc:667: Failure
base->ConfigureFromString(prepared, "unique={id=P; can_prepare=true}")
NotFound: Missing configurable object: pointer
terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException'
  what():  options/customizable_test.cc:667: Failure
base->ConfigureFromString(prepared, "unique={id=P; can_prepare=true}")
NotFound: Missing configurable object: pointer
Received signal 6 (Aborted)

Steps to reproduce the behavior

./customizable_test
@Yuval-Ariel Yuval-Ariel added the bug Something isn't working label Jun 23, 2022
@Yuval-Ariel
Copy link
Contributor Author

SPDB-556 was included in PR #2

@isaac-io
Copy link
Contributor

isaac-io commented Jun 23, 2022 •
edited

This doesn't happen with the original commit on 6.22.1. I'm assuming the rebase missed something?

EDIT: Nope, my bad. In my haste I reset the flags from kAllowNull to kNone. I opened a PR to fix it.

isaac-io added a commit that referenced this issue Jun 23, 2022
@isaac-io
customizable_test: fix breakage caused by changes introduced as part …
dc7d27a 
…of SPDB-556 (#27)

When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
@isaac-io isaac-io mentioned this issue Jun 23, 2022
Merged
@isaac-io isaac-io linked a pull request Jun 23, 2022 that will close this issue
#27: customizable_test: fix breakage caused by SPDB-556 #28
Merged
isaac-io added a commit that referenced this issue Jun 23, 2022
@isaac-io
customizable_test: fix breakage caused by changes introduced as part …
8fccd42 
…of SPDB-556 (#27)

When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
isaac-io added a commit that referenced this issue Jun 23, 2022
@isaac-io
customizable_test: fix breakage caused by SPDB-556 (#27)
4044df3 
When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
isaac-io added a commit that referenced this issue Jun 26, 2022
@isaac-io
customizable_test: fix breakage caused by SPDB-556 (#27)
f8df6ca 
When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
@isaac-io isaac-io mentioned this issue Jul 14, 2022
Closed
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
@isaac-io @Yuval-Ariel
customizable_test: fix breakage caused by SPDB-556 (#27)
09157e4 
When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
@Yuval-Ariel Yuval-Ariel mentioned this issue Jan 17, 2023
Open
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
customizable_test: fix breakage caused by SPDB-556 (#27)
686b3bc 
When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
udi-speedb pushed a commit that referenced this issue Oct 29, 2023
@isaac-io @udi-speedb
customizable_test: fix breakage caused by SPDB-556 (#27)
f05c877 
When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
udi-speedb pushed a commit that referenced this issue Dec 1, 2023
@isaac-io @udi-speedb
customizable_test: fix breakage caused by SPDB-556 (#27)
fb44add 
When fixing the clang compilation errors (offsetof() being applied
to non standard layout types), the pointer flags were mistakenly set
to `kNone` from `kAllowNone`. This didn't cause an issue with the tests
on 6.22.1, but it does after the rebase on 7.2.2. Add the missing flags
back so that the test passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#27: customizable_test: fix breakage caused by SPDB-556 speedb-io/speedb
2 participants
@isaac-io @Yuval-Ariel