Build related fixes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RocksDB currently fails to build with clang 12 due to newly added diagnostics. This is problematic for fuzz testing in CI and for developers building locally with clang, and thankfully these are easily fixable.
Currently the CMake config only looks for ccache, so developers using sccache need to manually set the launch commands. Add a check for sccache to spare them the trouble. While at it, clean up the CMake config and remove ccache as the link launch wrapper since it will just forward to the underlying linker anyway, and also regenerate the buck TARGETS file (we might want to drop support for it at some point, but for now let's keep it consistent).
isaac-io
approved these changes
Jun 6, 2022
|
I see that SPDB-181 was omitted for some reason. Was that intentional? |
it was never labeled as infrastructure since it started with "tests:" . should it be included? |
|
My bad for missing it during the classification, then. Yes, that's also a build-related fix, so should be included. Also note that SPDB-87 is a build-related fix and should be included as well. |
This commit originally imported fuzzing tools from rocksdb. However, after the rebase on 6.21 (from 6.11.4) only the compilation fixes are left. Original commit message: Building them is a bit of a pain, but the OSS-Fuzz build scripts are a good reference on how to do that: https://github.com/google/oss-fuzz/tree/master/projects/rocksdb This commit also fixes some clang compilation errors.
isaac-io
approved these changes
Jun 6, 2022
|
Closing as this was merged as part of #8 . |
udi-speedb
added a commit
that referenced
this pull request
Jun 29, 2022
udi-speedb
added a commit
that referenced
this pull request
Jun 29, 2022
Closed
udi-speedb
added a commit
that referenced
this pull request
Jul 24, 2022
udi-speedb
added a commit
that referenced
this pull request
Aug 24, 2022
udi-speedb
added a commit
that referenced
this pull request
Aug 25, 2022
udi-speedb
added a commit
that referenced
this pull request
Sep 5, 2022
udi-speedb
added a commit
that referenced
this pull request
Sep 6, 2022
udi-speedb
added a commit
that referenced
this pull request
Sep 19, 2022
udi-speedb
added a commit
that referenced
this pull request
Sep 22, 2022
udi-speedb
added a commit
that referenced
this pull request
Nov 30, 2022
udi-speedb
added a commit
that referenced
this pull request
Dec 6, 2022
udi-speedb
added a commit
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7