22 spdb memtable #30
Merged
22 spdb memtable #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
udi-speedb
force-pushed
the
22-spdb-memtable
branch
from
93599d7
to
defd556
Compare
isaac-io
force-pushed
the
22-spdb-memtable
branch
from
defd556
to
896ec2c
Compare
isaac-io
approved these changes
Jul 28, 2022
isaac-io
force-pushed
the
22-spdb-memtable
branch
from
896ec2c
to
662b0a6
Compare
This memtable supports concurrent readers and writers and provides much better results for insertions and point selections than the skip list memtable, while maintaining more tolerable iteration performance than the built-in RocksDB hash-based memtable.
isaac-io
force-pushed
the
22-spdb-memtable
branch
from
662b0a6
to
27532b2
Compare
isaac-io
added a commit
that referenced
this pull request
Jul 31, 2022
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
isaac-io
added a commit
that referenced
this pull request
Jul 31, 2022
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 23, 2022
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 25, 2022
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Apr 30, 2023
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
udi-speedb
pushed a commit
that referenced
this pull request
Oct 31, 2023
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 1, 2023
A last minute change before merging #30 breaks builds that configure `-Werror=unused-parameter` (this is the default for some GCC versions with the `-Wextra` configuration). Fix it by not declaring the `logger` argument to the `CreateMemTableRep()` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.