-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Configurable::SerializeOptions method to return a map #619
Changes from all commits
6dd7279
983f42f
846dd2a
8df931c
b373e4f
a7fb784
70392c9
7a80d1c
aded70d
6efcbb9
829da3f
253cf62
303570f
9dd077a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2197,6 +2197,8 @@ TEST_F(DBBasicTest, DBSetThreadAffinity) { | |
CPU_ZERO(&cpuset); | ||
CPU_SET(0, &cpuset); | ||
pthread_setaffinity_np(thr, sizeof(cpu_set_t), &cpuset); | ||
#else | ||
(void)thr; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a [[maybe_unused]] attribute There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is here because of a general build issue on Macs. I have fixed this in many PRs now. Hopefully one will take... |
||
#endif | ||
}; | ||
options.on_thread_start_callback = | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace "" with "" /* prefix */ for clarity