Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proactive Flushes: Fix a race in the ShouldInitiateAnotherFlushMemOnly that may cause the method to return an incorrect answer #759

Conversation

udi-speedb
Copy link
Contributor

No description provided.

…y that may cause the method to return an incorrect answer
Copy link
Contributor

@ofriedma ofriedma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves potential int overflow, LGTM

@udi-speedb udi-speedb merged commit f537bcd into main Nov 10, 2023
12 checks passed
@udi-speedb udi-speedb deleted the 758-proactive-flushes-wbmshouldinitiateanotherflushmemonly-may-return-incorrect-result-due-to-a-race branch November 10, 2023 16:03
udi-speedb added a commit that referenced this pull request Nov 19, 2023
…y that may cause the method to return an incorrect answer (#759)
udi-speedb added a commit that referenced this pull request Nov 23, 2023
…y that may cause the method to return an incorrect answer (#759)
udi-speedb added a commit that referenced this pull request Dec 6, 2023
…y that may cause the method to return an incorrect answer (#759)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proactive Flushes: WBM::ShouldInitiateAnotherFlushMemOnly may return incorrect result due to a race
2 participants