Potential risk for dropped listeners in UI

[Pyknic]

Many methods in the UI takes a StringProperty or a StringBinding as a parameter. Users of those methods must make sure to store a reference to the property before passing it as a parameter. Otherwise there is a risk that the property will be garbage collected as JavaFX mostly uses weak bindings.

Example:

StringProperty foo = new SimpleStringProperty();

void setValueOfFoo(StringProperty property) {
    foo.bind(property);
}

...

setValueOfFoo(new SimpleStringProperty("bar"));

In this case, the property with the value "bar" might be garbage collected sometime in the future as the reference is dropped. The only way to notice this is that foo will no longer be updated.

[Pyknic]

I have fixed some places where I have encountered this but there might be more places. I will let this remain open for a while longer.

[Pyknic]

I think this has been fixed everywhere now.