getVideoFrameURL is hard-coded to use https://www.webpagetest.org as the domain

[rsahlstrom]

We're using a private instance of webpagetest and not publishing our results publicly. As a result, the images are not pushed up to https://www.webpagetest.org. However, they are published on our private ec2 instance.

Looking at getVideoFrameURL though, it's hard-coded to always try to load the images form webpagetest.org.

speedtracker/app/Utils.js

Line 44 in 2c5b717

return `https://www.webpagetest.org/getfile.php?test=${id}&video=video_1&file=frame_${frame}.jpg`

Is it possible to instead use the value in wptUrl instead as the base URL for getVideoFrameURL?

[eduardoboucas]

Absolutely. I'll look into this.

[eduardoboucas]

This is a bit more complex than what I had anticipated. The value for wptUrl is configured in the main configuration file (speedtracker.yml), which is never accessed by the dashboard — it doesn't even know how to locate or read this file.

One possible solution for this would be to move this value to the profile files, which are accessible by the dashboard. This would have the added benefit of allowing different profiles to use different WPT instances, which is a feature that was suggested in the past (ping @iamnmtd).

Would you be against this?

[rsahlstrom]

That'd be fine with me. Thanks for figuring this out.

…

On Mar 25, 2017, 7:32 AM -0600, Eduardo Bouças ***@***.***>, wrote: This is a bit more complex than what I had anticipated. The value for wptUrl is configured in the main configuration file (speedtracker.yml), which is never accessed by the dashboard — it doesn't even know how to locate or read this file. One possible solution for this would be to move this value to the profile files, which are accessible by the dashboard. This would have the added benefit of allowing different profiles to use different WPT instances, which is a feature that was suggested in the past (ping @iamnmtd (https://github.com/iamnmtd)). Would you be against this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#34 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AApXlOh95rW3_IExutvtzqUWA63krVbyks5rpRdcgaJpZM4Mbv24).

[eduardoboucas]

@janiv Could you help me test this?

To see if this works, you'll need to do two things:

• Update your dashboard: I deployed some changes to my fork of the SpeedTracker dashboard. You can get them by creating a pull request from my fork to yours. You'll also need to add your WPT URL to your profile, as shown here.

• Request a test using the staging API: I deployed a new version of the API to the staging instance, which lives at dev.speedtracker.org, as opposed to the live one at api.speedtracker.org. You'd need to request a test using this version and it'd need to be done using a GET or POST request and not using the UI at speedtracker.org. You can see how here.

I don't have a private instance to test with so I'd really appreciate if you could lend a hand.

Thanks!

[rsahlstrom]

This looked to be working for me. Filmstrip now works great with the private WPT instance in the profile.

[eduardoboucas]

Thanks for your help. This has been released as part of v1.1.1.