Build against Java 10 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ijSdkKotlinPluginCoords=org.jetbrains.kotlin:1.2.51-release-IJ2018.1-1 | ||
| ijSdkVersion=2018.2 | ||
| ijSdkKotlinPluginCoords=org.jetbrains.kotlin:1.2.51-release-IJ2018.2-1 | ||
| org.gradle.jvmargs=--add-modules=java.xml.bind,java.activation |
There was a problem hiding this comment.
Damn, this breaks build on JDK8
There was a problem hiding this comment.
workaround #477
artem-zinnatullin
added a commit
that referenced
this pull request
Aug 22, 2018
…lds (#477) PR #460 added jvm option for Gradle daemon that is not supported by JDK8, this PR suppresses default JVM behavior that causes build to fail with following message: ```console ./gradlew tasks Starting a Gradle Daemon FAILURE: Build failed with an exception. * What went wrong: Unable to start the daemon process. This problem might be caused by incorrect configuration of the daemon. For example, an unrecognized jvm option is used. Please refer to the user guide chapter on the daemon at https://docs.gradle.org/4.10-rc-1/userguide/gradle_daemon.html Please read the following process output to find out more: ----------------------- Unrecognized option: --add-modules=java.xml.bind,java.activation Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ``` It's not a great solution, as it hides the fact that we can accidentally pass unsupported jvm option, but it unblocks JDK8 builds for now. Ideally, we should be able to set different jvm options for different JDK versions cc @vanniktech
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.