Implement common console launcher #604
Conversation
| actual class ConsoleLauncher: AbstractConsoleLauncher() { | ||
| override fun parseArgs(args: List<String>): LauncherArgs { | ||
| return LauncherArgs( | ||
| listOf(ConsoleReporterType(ConsoleReporterType.Format.BASIC)), |
There was a problem hiding this comment.
@charleskorn eventually we need to parse args here, but for now lets send the default emulating what you had before.
| } | ||
|
|
||
| data class LauncherArgs( | ||
| val reporterTypes: List<ReporterType>, |
There was a problem hiding this comment.
In what scenario would you want to have multiple reporters?
There was a problem hiding this comment.
In gradle, sometimes you'd want to generate xml and html reports at the same time.
integration-test/build.gradle
Outdated
| @@ -28,6 +28,7 @@ kotlin { | |||
| dependencies { | |||
| implementation project(':spek-dsl') | |||
| implementation kotlin('test') | |||
| implementation project(':spek-runtime') | |||
| } | ||
| } | ||
|
|
||
| private fun parseArgs(args: List<String>): LauncherArgs { |
There was a problem hiding this comment.
@charleskorn I decided to parse the args in a very naive way.
| import org.spekframework.spek2.runtime.scope.Path | ||
| import org.spekframework.spek2.runtime.scope.ScopeImpl | ||
|
|
||
| data class DiscoveryRequest(val context: DiscoveryContext, val sourceDirs: List<String>, val paths: List<Path>) |
There was a problem hiding this comment.
Would it make sense for sourceDirs to be on the JVM version of DiscoveryContext rather than on DiscoveryRequest?
There was a problem hiding this comment.
Yep, but I'll work on it on a separate PR to minimise the changes here.
| private fun parseArgs(args: List<String>): LauncherArgs { | ||
| var rawReporterType: String? = null | ||
| var rawConsoleReporterFormat: String? = null | ||
| var reportExitCode = false |
There was a problem hiding this comment.
Shouldn't this default to true?
|
Looks good to me. |
@charleskorn resolves #600
I think the infrastructure/api is mostly there, the only bit is parsing the command line arguments and wiring them up.