Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with TestCaseNameParser.cs #35

Closed
marc-delhoune opened this issue Jan 3, 2023 · 3 comments · Fixed by #36
Closed

Problem with TestCaseNameParser.cs #35

marc-delhoune opened this issue Jan 3, 2023 · 3 comments · Fixed by #36

Comments

@marc-delhoune
Copy link

Hi,

If the name of a test (namespace, class, of method) contains a zero (0), the new TestCaseNameParser.cs fails.
The MethodRegex and ClassDataRegex check for [a-z1-9_.], so they do not allow a zero. Should this be [a-z0-9_.] instead?

Using 'Parser=Legacy' solves my problem for now.

Best regards,

Marcus
Siphonophora added a commit to Siphonophora/testlogger that referenced this issue Jan 21, 2023
@Siphonophora
Resolve spekt#35
2a5de71
@Siphonophora Siphonophora mentioned this issue Jan 21, 2023
Merged
@Siphonophora
Copy link
Contributor

@marc-delhoune Thanks for reporting this. yes 0 should be allowed. We will work on getting the fix pushed out for this. Which logger are you using?

@marc-delhoune
Copy link
Author

I was using XunitTestAdapter.

codito pushed a commit that referenced this issue Jan 24, 2023
@Siphonophora
Fix nameparser regex issue (#36)
10d5368 
* Add failing tests
* Resolve #35
codito added a commit to spekt/xunit.testlogger that referenced this issue Jan 26, 2023
@codito
fix: testcase name parser regex to include zero.
97912ac 
spekt/testlogger#35
@codito codito mentioned this issue Jan 26, 2023
Merged
codito added a commit to spekt/xunit.testlogger that referenced this issue Jan 29, 2023
@codito
fix: testcase name parser regex to include zero. (#42)
3754fbb 
spekt/testlogger#35
@codito
Copy link
Contributor

codito commented Jan 30, 2023

Pushed testlogger v3.0.86 to all logger and cut a release in nuget. /cc: @Siphonophora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nameparser regex issue Siphonophora/testlogger
3 participants
@codito @Siphonophora @marc-delhoune