panel-navigation: rm need for javascript #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#download` panel does not work yet based on https://dev.to/hakash/100-pure-htmlcss-page-navigation---no-javascript-required-2em5 related: spesmilo#3
The panel-navigation introduced in the prev commit, which works without javascript, (using css), has a restriction: all panels/pages have to be contained in a single html file. To accommodate this, this commit inlines panel-download.html into index.html. Previously we had - panel-download.html.template => panel-download.html - index.html Now we have - panel-download.html.template + index.html.template => index.html electrum/contrib/make_download in the client repo is also adapted.
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
May 22, 2023
|
I recommend reviewing commit-by-commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master, the website requires javascript for the panel-navigation (to switch between e.g. the "home", "download", "about", etc. pages). This PR adds a CSS-based approach instead. This makes the website functional without javascript.
Note that the navigation still works a bit "better" if javascript is enabled, as without it the browser ~jumps to the top of the html anchor when switching panels. If javascript is available, I am using a trick to avoid this behaviour.
The slideshow still requires javascript, it is blank without it.
closes #3