Confirming New Contact dialog with valid input switches to Console tab #1986
Comments
Toporin
pushed a commit
to Toporin/electrum-satochip
that referenced
this issue
Jan 12, 2021
* added unbroadcasted send * added kt file for unbroadcast tx * fix coldsend dialog title * add load unbroadcasted tx * add load tx kotlin file * cleanup * Delete local.properties not for vcs * added missing files * removed generated files * remove files * cleanup * fix qr code in coldload * change buttontext ok to sign * cleanup whitespace * remove ColdSend.kt and add sign unbroadcasted to Send.kt * format comments and remove paste button enabler * removed accidently added package to main.kt * change name of paste button * remove toast used for testing * toast errors from broadcasting transactions * fix toast message on tx broadcast * comment fix * fix result toast * fixes * rename variables * change title to sign transaction * remove redundent declaration * remove extraneous generated files * copy Util.kt from original repo * replace original gitignore and project_default files * whitspace cleanup * check if connected before broadcasting Cold tx * refactor if statement * Check whether clipboard is empty before pasting: It never seems to be empty on the emulator, but I was able to make the app crash on a physical device by trying to paste after a reboot. * Fix ColdLoad toast issues: It was passing a string to a method which expected a transaction, so the method always returned failure. Detecting "success" by looking for "txid" in the text of the error message isn't reliable, because that string could also appear in a real error. Changed to reuse the existing result checking code in Send.kt. * Fix ColdLoad send button being disabled after rotating screen: onShowDialog is called again after each rotation, so it can't unconditionally disable the button. * Revert irrelevant whitespace changes in Send.kt * Make "unbroadcasted" argument false by default so it doesn't have to be specified everywhere: Actually getBoolean already returns false by default, but it's better to be explicit. * Send.kt cleanups: * Make unbroadcasted flag an instance variable rather than a global. * Fix duplicate code in `if` statements. Co-authored-by: Matthew Clancy <matthewpclancy@mpc.local> Co-authored-by: Malcolm Smith <smith@chaquo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The contact is added and everything works as supposed, but the main window switches to the Console tab. This is on the OS X client.
How to reproduce:
This line might be the cause of this behavior.
The text was updated successfully, but these errors were encountered: