Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segwit message signing is not compatible with other software #3861

Open
SomberNight opened this issue Feb 6, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@SomberNight
Copy link
Member

commented Feb 6, 2018

AFAICT there is no clear consensus how to sign messages with segwit addresses (txin type of p2wpkh-p2sh and p2wpkh)

We do one thing, and Trezor does something else. Bitcoin Core so far has this disabled.
Maybe we could transition to what Trezor does, in a way that:

  • signatures created by new Electrum
    • can be verified by new Electrum software, but not verified by old
  • signatures created by old Electrum
    • can be verified by both new and old Electrum

Electrum issue/commit

Bitcoin Core issue

Trezor issue/commit/tests

gribble PR doing what Electrum does

@bauerj bauerj added the enhancement label Feb 6, 2018

@ecdsa

This comment has been minimized.

Copy link
Member

commented Feb 6, 2018

I don't mind following what trezor does.
The only drawback is that we might have to change it again if Core introduces a new method

@matejcik

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

at the moment Trezor-generated signatures will fail to verify in Electrum because how from_signature65 decodes it. That's probably worth fixing, without touching the other parts.

@Giszmo

This comment has been minimized.

Copy link

commented Apr 9, 2019

Is there any consensus yet on test vectors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.