"script_error_messages" needs a fix

[Coding-Enthusiast]

electrum/electrum/network.py

Line 919 in 7ac1cac

r"Only non-push operators allowed in signatures",

This was a wrong error message in bitcoin core which was fixed in 18412 today.
You may need to add a condition before returning the correct message for backward compatibility.

if serverMsg == "Only non-push operators allowed in signatures" or  == "Only push operators allowed in signatures"
return "Only push operators allowed in signatures"
else
// line 938 to 940 as it was before:
  for substring in script_error_messages:
      if substring in server_msg:
          return substring

[SomberNight]

Thanks.

You may need to add a condition before returning the correct message for backward compatibility.

You are right that this would be the nice approach but it also makes the code a bit more complicated.

I don't think I've ever seen this error message except when I was writing new code to manually construct transactions. It does not happen for production releases. And if it happens for a dev, they can just look at the log that contains the original message.

So, I think it's fine to only handle the msg returned by updated bitcoind.