Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCRIPT_ERR_SIG_PUSHONLY error string is wrong #18411

Closed
Coding-Enthusiast opened this issue Mar 23, 2020 · 1 comment · Fixed by #18412
Closed

SCRIPT_ERR_SIG_PUSHONLY error string is wrong #18411

Coding-Enthusiast opened this issue Mar 23, 2020 · 1 comment · Fixed by #18412

Comments

@Coding-Enthusiast
Copy link

bitcoin/src/script/script_error.cpp

Lines 60 to 61 in 57a8fa9

case SCRIPT_ERR_SIG_PUSHONLY:
return "Only non-push operators allowed in signatures";

It should be Non-push operators are not allowed in signatures or Only push operators allowed in signatures.
@theStack theStack mentioned this issue Mar 23, 2020
Merged
@theStack
Copy link
Contributor

Good catch! As far as I saw no test relies on the string, so it can simply be corrected -- I opened a PR (#18412) to solve this issue.

@Coding-Enthusiast Coding-Enthusiast mentioned this issue Mar 27, 2020
Closed
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
1748cdb 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
088c640 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
9d6441d 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
825594e 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
651c487 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 14, 2021
@PastaPastaPasta
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
286acf3 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
gades pushed a commit to cosanta/cosanta-core that referenced this issue Apr 29, 2022
@gades
Merge bitcoin#18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
f8159a7 
41ff499 script: fix SCRIPT_ERR_SIG_PUSHONLY error string (Sebastian Falbesoner)

Pull request description:

  Fixes bitcoin#18411, changing the error message from `"Only non-push operators allowed in signatures"` to `"Only push operators allowed in signatures"`.

ACKs for top commit:
  laanwj:
    ACK 41ff499

Tree-SHA512: 3b75d83e2198d638d599ef6a4a8da986f0158600fe3f89f55b3759554588157acf2b0cba3f6a907164617264e7aee727d6d460b510c8b37ca7728aa79e11ad80
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

script: fix SCRIPT_ERR_SIG_PUSHONLY error string theStack/bitcoin
2 participants
@theStack @Coding-Enthusiast