Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering (partial?) removal of OpenAlias support. Comment here if you use it. #6232

Open
SomberNight opened this issue Jun 13, 2020 · 15 comments

Comments

@SomberNight
Copy link
Member

With recent refactoring of invoices/payment requests, OpenAlias support is now partially broken.
Looking up an OpenAlias (name -> addr) works, however

I am wondering whether this functionality is worth restoring/fixing.
We could remove the broken functionality;
or maybe we could strip OpenAlias support completely.

Do people actually use OpenAlias?
Do you use OpenAlias? What do you use it for?

If you want the project to keep supporting OpenAlias, please comment here.

@SomberNight SomberNight pinned this issue Jun 13, 2020
@SomberNight SomberNight changed the title Considering (partial?) removal of openalias support. Comment here if you use it. Considering (partial?) removal of OpenAlias support. Comment here if you use it. Jun 13, 2020
@fluffypony
Copy link
Contributor

I know of a fair number of people that use OpenAlias within Electrum, and we're actually busy with an OpenAlias v2 spec. There's also some activity around OpenAlias with Lightning, so I'd definitely push for it to continue.

A bip21 URI with OA embedded could get confusing, as the OA record itself could include an amount, so I'd veer away from that particular edge-case - unless we start to see adoption by payment processors that dictates revisiting this.

@relativisticelectron
Copy link
Contributor

relativisticelectron commented Jun 28, 2020

Is this not a huge privacy leak (without paynyms) and should not be used?

@fluffypony
Copy link
Contributor

@relativisticelectron yes, but that doesn't mean it's not useful. OpenAlias is a very broad standard, and works with Monero (for instance) where privacy isn't an issue. It already allows you to specify a Lightning invoice (via oa1:lightning), which may be somewhat useless given the nature of DNS, but there will be long-lived LN payment mechanisms in future that OA will support.

@ysangkok
Copy link
Contributor

@fluffypony keysend is already supported in LND and c-lightning: https://lightning.readthedocs.io/lightning-keysend.7.html

@fluffypony
Copy link
Contributor

@ysangkok awesome that's great news!

@JeremyRand
Copy link
Contributor

Namecoin is interested in OpenAlias (specifically using .bit domains for OpenAlias records), so we'd definitely vote for keeping the OpenAlias support present. Definitely would be useful to fix the privacy leaks associated with address reuse though.

@losnappas
Copy link

Who is this built for? Is there even a UI for registering an alias? I think it's junk, have not seen anybody use it.

@fluffypony
Copy link
Contributor

@losnappas when you say stuff like "is there a UI for registering an alias" you demonstrate that you have no clue what you're talking about, didn't bother reading up on it, and are merely giving your uninformed opinion for some narcissistic reason. Feel free to come back to this conversation when you've actually done a smattering of research.

@losnappas
Copy link

Whoa there.

I was just giving the 2 cents of the average user. "for some narcissistic reason"? Calm down.

@fluffypony
Copy link
Contributor

I was just giving the 2 cents of the average user. "for some narcissistic reason"? Calm down.

If that was the case you would have just said "I don't personally know anyone using it". Comments like "it's junk" have no place here.

@losnappas
Copy link

Right, I thought that that was more of a funny thing to say, but I guess people will read it with another tone in mind.

My apologies

@dunnock
Copy link

dunnock commented Oct 17, 2020

This really helps to send coins to people I personally know, instead of keeping hexadecimal addresses at hand for copy pasting. Please don't remove.

@delta1
Copy link

delta1 commented Oct 18, 2020

Another vote to please keep OpenAlias support, I use it regularly and I'm certain many more people (that may never see this issue do as well).

@stringhandler
Copy link

I'll like the project to keep supporting OpenAlias

SomberNight added a commit to SomberNight/electrum that referenced this issue Apr 8, 2021
Before upgrading `dnspython` to 2.0 in spesmilo#6828, we have supported both
`pycryptodomex` and `cryptography` as crypto backends. We use `dnspython`
for DNSSEC, and also some other things. The DNSSEC part of `dnspython` is
an optional extra which requires `cryptography`. This is why we removed
the choice of `pycryptodomex` as a backend: we would need `cryptography`
for DNSSEC anyway.

Note that DNSSEC is only used for OpenAlias, which itself is probably
only used by a handful of people. We have considered removing OpenAlias
support as then we could also remove DNSSEC, see spesmilo#6232.

Recently `cryptography` (since version 3.4) started using Rust code, which
necessitates having a Rust compiler if building from source (see https://github.com/pyca/cryptography/blob/58f0ad5b6b928677931c7ad44deee839a29ee9d3/CHANGELOG.rst#34---2021-02-07 ).
Some people complained this is problematic for them.

With this PR, we restore the choice between `pycryptodomex` and `cryptography`.
(Though the code that can utilise either backend has not even been removed,
it is in `crypto.py`)
We support having either dependency; with the caveat that DNSSEC is only
available if `cryptography` is available.
@artk42
Copy link

artk42 commented Jul 21, 2021

Is there any further activity re OA v2 spec? The site looks doomed..

@accumulator accumulator unpinned this issue Dec 31, 2022
SomberNight added a commit that referenced this issue Mar 14, 2023
Probably got broken in #7839 ,
which got released in 4.3.0, ~7 months ago.
As no one complained, this really again raises the question of removing openalias...

related #6232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants