-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lnurl-pay (LUD-06
) support
#7839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
force-pushed
the
202202_lnurl_2
branch
3 times, most recently
from
June 7, 2022 14:36
583b020
to
4e09d04
Compare
* bundles all payment identifiers into handle_payment_identifier * adds lnurl decoding * adds lightning address decoding
- add param to _check_text to toggle if network requests are allowed ("full check") - every 0.5 sec, if the textedit has no focus, do full check - on textChanged() - detect if user copy-pasted by comparing current text against clipboard contents, if so, do full check - otherwise, do partial check - on clicking ButtonsWidget btns (scan qr, paste, read file), do full check
SomberNight
force-pushed
the
202202_lnurl_2
branch
from
June 29, 2022 14:25
4e09d04
to
81e418b
Compare
SomberNight
changed the title
add lnurl-pay (
add lnurl-pay (Jun 29, 2022
LUD-06
) and lightning address (LUD-16
) supportLUD-06
) support
- in lnurl.py, make request methods async - in Qt GUI, lnurl network requests no longer block the GUI thread - but they still do in the kivy GUI - "lightning address" (LUD-16) support is removed for now as the email addresses are indistinguishable from openalias email addresses (both protocols should have added and enforced a prefix, or similar, to remove this kind of ambiguity -- now we would need to make a network request just to identify what kind of ID we were given)
SomberNight
force-pushed
the
202202_lnurl_2
branch
from
June 29, 2022 14:56
81e418b
to
ed1567e
Compare
Closed
SomberNight
added a commit
that referenced
this pull request
Mar 14, 2023
probably got disabled in or around #7839 by accident
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #7573 and #7683, and some clean-up commits.
Support for paying to "lnurl-pay" is added to the Qt and kivy GUIs.
"lightning address" (
LUD-16
) support is not added for now, mainly as the email-address-like format is ambiguous and cannot be distinguished from e.g. openalias.Unlike in a previous version of this PR, in the Qt GUI, the network requests are not done on the GUI thread, instead they are async and use qt signals.
Re the kivy GUI, they are still running on the GUI thread and blocking the GUI. This can be fixed later or as a follow-up.
closes #7573
closes #7683
Re Qt paytoedit specifically, it seems hard to have good UX.
There are design questions, such as
if so, do full check
note that "openalias" ids and "lightning address" ids can both look like email addresses and hence can collide. how to handle this?we give priority to "lightning address" and do network request for that firstif that fails, we do "openalias" network requestExamples to test in Qt paytoedit:
mempool@jhoenicke.de
lightning:lnurl1dp68gurn8ghj76ngdajku6trddjjuer99uh8wetvdskkkmn0wahz7mrww4excup0d4jk6ur0dakqhmhnx2
lnbc3680n1p3zka2ypp5nf74fk49ehwmqfdkwfn86q4pgytjttrdqa4gg64v7tntrf5ws9vsdpdg3hkuct5d9hkugrxdaezqjn0dphk2fmnypkk2mtsdahkccqzpgxqyz5vqsp5d69tlczphwcg62p9pc307yd59f2xacnkdhfsnxx3a7pgmhmmmg7q9qyyssqdnhpzxrhf47x5srjxmzv8wq7mkeuyca0lqy55vvfxxtqdguc67mhy9s8qhvn9fpmk65qs36e06gj3rmvslalf9mds8ptlssfnu5kkfspyrxu2p
donate.getmonero.org
donate@getmonero.org
bitcoin:?r=https://bitpay.com/i/5V4bqzj8xHs5UepqA9WCzw
bc1qq2tmmcngng78nllq2pvrkchcdukemtj56uyue0