-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature, Subtract fee from amount + RBF, Important for privacy. Offering 1.5m sat. ($350) #6783
Comments
@Transisto what do you mean? |
It would be extremely useful for when a customer is asking to increase his transaction priority via RBF and has already paid with cash and left. Having the option in RBF panel would also increase privacy chain wide by removing the general assumption that the extra fee for the new RBF transaction is taken from the change. I'm offering a tip of 100 000 sat for that feature as an option in the RBF panel. |
Sorry I meant 1m sat, bumping it to 1.5m sat (~350USD at of now) |
To be clear, do you mean there could be an option for this in the "bump fee dialog"? So only when increasing the fee of an existing tx? -- as opposed to during initial construction of a tx |
I mean it'd be great if fee could be taken from amount when creating the first transaction, like the wallets above, but for us that can already be calculated easily, What's more useful for us is to make the customer pay after he left but call to request a speed up. But yeah, the option doesn't need to be part of the fee increase dialog if the wallet just remember where to take the fee when it was first created. BTW Bitcoin core take into account pay to many and will take the fee evenly from all outputs. |
What does "evenly" mean? |
Good point, it should be based on data weight of the utxo but I think
disregarding the address type is good enough, although I think we should
consider doing the same thing as Bitcoin Core to avoid wallet fingerprints.
`subtractfeefrom'
https://chainquery.com/bitcoin-cli/sendmany
…On Fri., Dec. 25, 2020, 09:45 ghost43, ***@***.***> wrote:
BTW Bitcoin core take into account pay to many and will take the fee
evenly from all outputs.
What does "evenly" mean?
Is the amount taken away linearly scaled according to the output values,
or are all outputs decreased by the same value?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6783 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC643DF3T3RHLFUJREQMZDSWSQSFANCNFSM4UDQBJPA>
.
|
I think adding this "subtract fee from payment amount" option to the However, you can not achieve this currently with So then the question is, what to do if there are multiple non-ismine outputs -- so for |
I'm not sure what non-isimine means but if it means, of different amount then I'd say only data weight of the output matters. Transactions should be able to pay for their own weight and when batching someone buying for 50$ pays the same network fee as someone buying for 5000$ |
An address is So what I meant there is: the question is what to do if there are multiple external/foreign outputs. |
I think a variant of this is now implemented with #7026. Feel free to test and say if it does what you wanted. |
Somewhere on this tab could be a "Subtract fees from amount" checkbox.
The text was updated successfully, but these errors were encountered: