added local client variable #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
Toporin
pushed a commit
to Toporin/electrum-satochip
that referenced
this pull request
Feb 16, 2021
…tSig (spesmilo#1648) fixes spesmilo#1628 continues the theme of spesmilo#1637 -- if an input has scriptSig, it *is* essentially complete. If people are doing smart contracts and need to save unsigned transactions, my recommendation for the initial wallet: - txin['type'] = 'unknown' - set txin['scriptSig'] to anything you want, but I recommend making sure the first couple of bytes are 0000 or ffff, something like that, which ensures it won't get misinterpreted as one of the special input types. You can even embed metadata or signatures here, go wild. Upon loading the transaction, Electron Cash will think that input is of an unknown type (good) but also thinks it is complete (wrong). As a result, the user will be presented with the ability to broadcast the tx, which will of course fail. It's your job as smart contract author to do something about that. Perhaps we can add a hook at the end of `Transaction.deserialize()`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue 1605