Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: pre-Windows10 binaries #3185

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

SomberNight
Copy link
Member

@SomberNight SomberNight commented Nov 2, 2017

See #3171

This is essentially "stolen" from pyinstaller/pyinstaller#1566 (comment)

With this, binaries should work on Windows 10 by default (as with 3.0.0).

On Windows 7 and 8.1, binaries might work by default; if they don't work, the end-user should

Either of these two things should fix it. To clarify, the end-user has to install one of these.
Hence I would call this a "hotfix".

I've tested on Windows 10 and 7; and skace (from #electrum) tested on 8.1 - thanks for that.
No idea about earlier Windows versions.

These are the DLLs we are removing (in my dev environment):

{('api-ms-win-crt-stdio-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-stdio-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-filesystem-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-filesystem-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-multibyte-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-multibyte-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-locale-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-locale-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-process-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-process-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-time-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-time-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-math-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-math-l1-1-0.dll', 'BINARY'),
 ('MSVCR100.dll', 'C:\\windows\\system32\\msvcr100.dll', 'BINARY'),
 ('api-ms-win-crt-convert-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-convert-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-string-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-string-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-conio-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-conio-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-runtime-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-runtime-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-environment-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-environment-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-heap-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-heap-l1-1-0.dll', 'BINARY'),
 ('api-ms-win-crt-utility-l1-1-0.dll', 'C:\\windows\\system32\\api-ms-win-crt-utility-l1-1-0.dll', 'BINARY')}

The MSVCR100.dll seems to be redundant. The 'api-ms-win-crt-* DLLs are stubs from Wine, which don't actually work on Windows. I think 3.0.0 only works on Windows 10 as it somehow successfully fallbacks to the real DLLs which are part of Win10 by default. The above linked Win update or the VC++ redist both make sure that these are available on the older Windows versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants