trezor plugin: native segwit #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3551
Please test with #3630 also merged
Note that e218c4a still does not allow creating a wallet with a hw device using bip84 (so comment that out to test)
Also note that you need git HEAD of python-trezor as #3621 broke compatibility with the latest released version.
Also note that spending from multisig with Trezor is broken on master currently (#3680) regardless of this PR.
I've tested
p2pkh("bip44") /p2wpkh-p2sh("bip49") /p2wpkh("bip84") wallets with Trezor; creating single/multi-input transactions to multiple outputs (with and without change) of mixed type: p2pkh and p2sh and p2wpkh.