Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change WIF to "txin_type:old_wif" #3925

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

SomberNight
Copy link
Member

@SomberNight SomberNight commented Feb 19, 2018

  • new versions always export as txin_type:wif (0x80 first byte)
    • we no longer import and export private keys "as-is". when exporting, everything is re-serialized as txin_type:wif, even minikeys
  • new versions allow importing
    • txin_type:wif (only 0x80 first byte allowed)
    • wif -- and this format allows other first bytes; guess txin_type based on them
      • provides backwards compat for our "3.0.x extended WIF"
  • internally, Imported Wallet keystores keep storing privkeys using "3.0.x extended WIF"

Related: #3620, #3881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants