New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: fix icon path for user installation #4149

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
3 participants
@toxeus
Contributor

toxeus commented Mar 20, 2018

Before, the user installation used the wrong directory
to store the application's icon resulting in the desktop
environment falling back to an ugly default icon. Now,
the correct icon is displayed in the menu.

"By default, apps should look in $HOME/.icons (for backwards
compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps
(in that order)."
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

Contributed by FDF

setup.py: fix icon path for user installation
Before, the user installation used the wrong directory
to store the application's icon resulting in the desktop
environment falling back to an ugly default icon. Now,
the correct icon is displayed in the menu.

"By default, apps should look in $HOME/.icons (for backwards
compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps
(in that order)."
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
@bauerj

This comment has been minimized.

Member

bauerj commented Mar 20, 2018

That sounds right but doesn't your commit put it in ~/.local/share/icons if $XDG_DATA_HOME is not set? According to your quote it should look in ~/.icons in stead.

@toxeus

This comment has been minimized.

Contributor

toxeus commented Mar 20, 2018

Nope. ~/.icons should not be used by new apps that's why they explicitly mention it as backwards compatibility. ~/.local/share is the XDG spec's fallback if $XDG_DATA_HOME is not set.

spec:

$XDG_DATA_HOME defines the base directory relative to which user specific data files should be stored. If $XDG_DATA_HOME is either not set or empty, a default equal to $HOME/.local/share should be used.

@bauerj bauerj added this to the 3.2.0 milestone Mar 20, 2018

@ecdsa ecdsa merged commit 064fdac into spesmilo:master Mar 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 43.927%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment