sdist build: let pip install put ~everything from tar.gz to site-packages #7145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages (well, not everything, only files in electrum/ (so e.g. not contrib)) See comment in setup.py. E.g. we have been including the www/ folder in the tar.gz but have not been installing it to site-packages. Now we do. Or we have been including the kivy GUI files in the tar.gz but not installing them. Now we do. I like this because it simplifies setup.py and should be easier to reason about too. should fix spesmilo#7089 (at least when using the tar.gz)
|
that looks good to me. why is it still a draft? |
|
I wanted to do some more checks that it behaves as expected. I did a few builds now, and they looked ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes pip install copy ~all files from the tar.gz to site-packages.
(well, not everything, only files in
electrum/(so e.g. notcontrib))See comment in
setup.py.E.g. we have been including the www/ folder in the tar.gz but have not been installing it to site-packages. Now we do.
Or we have been including the kivy GUI files in the tar.gz but not installing them. Now we do.
I like this because it simplifies setup.py and should be easier to reason about too.
should fix #7089 (at least when using the tar.gz)
related:
pypa/sampleproject#30 (comment)
pypa/sampleproject#30 (comment)
(most of that thread really)