wallet: refactor check_sighash/risk_of_burning_coins_as_fees #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- risk_of_burning_coins_as_fees is turned into a private (helper) method, only called by check_sighash. UIs should only care about check_sighash. - check_sighash returns instance of new class "TxSighashDanger" instead of tuple - made warning levels more fine-grained (FEE_WARNING_SKIPCONFIRM vs FEE_WARNING_NEEDCONFIRM) - this became more complicated than I had hoped for but I think it is worth it to ~merge check_sighash and risk_of_burning_coins_as_fees into one. related spesmilo#8699
SomberNight
commented
Dec 13, 2023
| @@ -362,7 +362,7 @@ Pane { | |||
| onClicked: { | |||
| if (txdetails.shouldConfirm) { | |||
| var dialog = app.messageDialog.createObject(app, { | |||
| text: qsTr('Confirm signing non-standard transaction?'), | |||
| text: qsTr('Confirm signing transaction despite warnings?'), | |||
There was a problem hiding this comment.
note: I've changed this phrasing as "(non-)standard transaction" has a specific meaning in bitcoind (re relay policy) and hence I found it confusing. Though most users probably don't know that meaning. Still, I think it is better not to overload the term.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #8699