Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip21: fail bip21 uri if unsupported req-* parameter is present. #8789

Merged

Conversation

accumulator
Copy link
Member

fixes #8781

@SomberNight
Copy link
Member

note: the most appropriate error message about the particular key being unknown is not shown to the user in neither the qml nor the qt GUI.

@SomberNight SomberNight merged commit 926756c into spesmilo:master Jan 4, 2024
9 of 14 checks passed
@accumulator accumulator deleted the bip21_req_params_validation branch February 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electrum doesn't consider BIP21 URI invalid when it contains unknown required parameters
2 participants