Add ToTimeInDefaultLocation/E #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
date-with-tz
branch
3 times, most recently
from
62d766f
to
2e435db
Compare
bep
changed the title
bep
force-pushed
the
date-with-tz
branch
2 times, most recently
from
2172ccb
to
69c1d41
Compare
bep
changed the title
Go's time parsing uses UTC when the format doesn't have a tiemzone, and has even weirder behavior when it has a zone name but no numeric offset. A caller to `cast.ToTime` won't know if the returned time was explicitly in UTC, or defaulted there, so the caller cannot fix it. These new functions allow a user to supply a different timezone to default to, with nil using the local zone.
bep
force-pushed
the
date-with-tz
branch
6 times, most recently
from
0881fcb
to
dc790bf
Compare
bep
changed the title
bep
force-pushed
the
date-with-tz
branch
9 times, most recently
from
f5b8561
to
089f9f4
Compare
This commit adjusts the previous commit re. the new `ToTimeInDefaultLocationE` and related functions.
The functional change is that we don't default to any location if not provided from the caller.
This is in line with how `ToTime` worked before we started this, and even if the default behaviour may look weird in some cases, it will not break anything.
Most applications will want to use the new *InDefaultLocation functions and decide which default location to use:
```go
loc := time.Local
if config.Location != "" {
loc = time.LoadLocation(config.Location)
}
t, err := StringToDateInDefaultLocation("2019-01-01", loc)
```
This commit also configure Travis to test on OSX and Windows in addition to Linux.
bep
changed the title
|
The context for this PR is described in #23 from @heewa I can just repeat here that the reason we don't use One example would be that |
|
This can be closed since e4dda5f. |
This was referenced Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.