Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shell_completions.md to have automatically rootcmd #1372

Merged

Conversation

georgettica
Copy link
Contributor

@georgettica georgettica commented Mar 31, 2021

this makes using this snippet easier

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2021

CLA assistant check
All committers have signed the CLA.

@georgettica
Copy link
Contributor Author

georgettica commented Mar 31, 2021

PS - it seems the MING64 fails because of a go install that is not backed by a go get

to bypass this you can cd $(mktemp -d) and do the go-get there, this would not add the deps to the package but will at some point require cleaning the /tmp/folder.* that are created

@georgettica
Copy link
Contributor Author

georgettica commented Mar 31, 2021

seems this fail was solved by #1366

Copy link
Collaborator

@marckhouzam marckhouzam left a comment

That is a good suggestion @georgettica, thanks! Just a couple of updates needed.

shell_completions.md Outdated Show resolved Hide resolved
shell_completions.md Outdated Show resolved Hide resolved
@georgettica
Copy link
Contributor Author

georgettica commented Apr 20, 2021

@marckhouzam fixed as you suggested, glad I could contribute :)

@georgettica
Copy link
Contributor Author

georgettica commented Apr 21, 2021

seems the MING64 issue is regarding #1348 and the comment I made there

@github-actions
Copy link

github-actions bot commented Jun 21, 2021

This PR is being marked as stale due to a long period of inactivity

@georgettica
Copy link
Contributor Author

georgettica commented Jun 21, 2021

Can this be assisted with?
I want this to be installed, but not sure how to do that

@georgettica
Copy link
Contributor Author

georgettica commented Jul 9, 2021

/retest

@georgettica
Copy link
Contributor Author

georgettica commented Jul 9, 2021

@marckhouzam how do I retest?

And is this issue solved in upstream that a rebase will work?

@marckhouzam
Copy link
Collaborator

marckhouzam commented Jul 9, 2021

@georgettica you can rebase on master and do a force-push

@georgettica georgettica force-pushed the georgettica/automatically-fill-rootcmd branch from 4e20211 to b0d065a Compare Jul 9, 2021
@georgettica
Copy link
Contributor Author

georgettica commented Jul 9, 2021

@marckhouzam done, need approval to run workflows

@georgettica
Copy link
Contributor Author

georgettica commented Jul 17, 2021

@marckhouzam can you remove the stale flag?
I did update as you requested recently

Hopefully this can be merged now

@marckhouzam
Copy link
Collaborator

marckhouzam commented Jul 17, 2021

@marckhouzam can you remove the stale flag?
I did update as you requested recently

I'm not a maintainer, I just help out as best I can. I expect this will be merged when we are closer to the next release.

@georgettica
Copy link
Contributor Author

georgettica commented Jul 17, 2021

From looking around @jpmcb has doneaa merge before.. maybe he can help?

And thanks for your help @marckhouzam

@georgettica
Copy link
Contributor Author

georgettica commented Aug 18, 2021

@jpmc maybe you can TAL ?
not sure who to ask for eyes on this

Copy link

@stmcginnis stmcginnis left a comment

Looks great to me!

umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 5, 2021
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 15, 2021
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
jpmcb
jpmcb approved these changes Dec 7, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Looks good! Thanks much for the patience here! ❤️

@jpmcb jpmcb merged commit d298d79 into spf13:master Dec 7, 2021
2 checks passed
@jpmcb jpmcb added this to the 1.3.0 milestone Dec 7, 2021
@georgettica georgettica deleted the georgettica/automatically-fill-rootcmd branch Dec 8, 2021
@georgettica
Copy link
Contributor Author

georgettica commented Dec 9, 2021

tested and it works!

found an issue I will file / check if it's not noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants