Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/MSYS2: go install @latest #1366

Merged
merged 1 commit into from May 3, 2021
Merged

ci/MSYS2: go install @latest #1366

merged 1 commit into from May 3, 2021

Conversation

@umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 12, 2021

Close #1365
Ref #1360 #1363

The behaviour of modules, get and install changed in golang 1.16: https://blog.golang.org/go116-module-changes. This PR fixes the problem on MSYS2 when trying to install richgo and gox.

@umarcor
Copy link
Contributor Author

@umarcor umarcor commented Mar 23, 2021

@jpmcb mind reviewing and maybe merging this?

@georgettica
Copy link

@georgettica georgettica commented Mar 31, 2021

got the same issue, glad it is addressed!
I hope this is merged soon 🤞

good job @umarcor

@raulb raulb mentioned this pull request Apr 16, 2021
jpmcb
jpmcb approved these changes May 3, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

LFTM! 🚀
would be nice if these had more of a release schedule, but doesn't look like they really make frequent releases or tags, so using the @latest seems to be the right thing here

@jpmcb jpmcb merged commit 3ed6a39 into spf13:master May 3, 2021
8 checks passed
@umarcor
Copy link
Contributor Author

@umarcor umarcor commented May 3, 2021

Thanks!
Agree. However, since these are "plumbing deps" and not something the tool (cobra) needs, I believe it's acceptable to be on the bleeding edge, even if we get hurt sometime.
Nonetheless, the relevant modification (the fix) is specifying the version (any).

@umarcor umarcor deleted the latest branch May 3, 2021
@jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented May 3, 2021

I agree, it's pretty low risk! Thanks again for this!

@jpmcb jpmcb mentioned this pull request May 3, 2021
@renovate renovate bot mentioned this pull request Jul 1, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants