Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use golangci-lint-action #1477

Merged
merged 1 commit into from Dec 7, 2021
Merged

chore(ci): use golangci-lint-action #1477

merged 1 commit into from Dec 7, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 26, 2021

This PR is to use golangci-lint-action instead of direct download of it's executable.
It allows also to see the tool's reviews outside of the logs in github.
I also formated and fixed the actual reviews.
Some linters were deprecated, so I used there actual versions

@github-actions github-actions bot added area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli area/docs-generation Generation of docs via Cobra admin For general admin tasks to be done usualy by maintainers labels Aug 26, 2021
.github/workflows/test.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
bash_completions.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the area/docs-generation Generation of docs via Cobra label Sep 11, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@github-actions github-actions bot removed the area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli label Sep 11, 2021
Copy link
Contributor

@umarcor umarcor left a comment

LGTM!

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

This PR is being marked as stale due to a long period of inactivity

umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 11, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@umarcor
Copy link
Contributor

umarcor commented Nov 11, 2021

Added to #1496 and #1525.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 15, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
Copy link

@stmcginnis stmcginnis left a comment

I know there are some linters that don't work well with go 1.17 that get pulled in with golangci-lint prior to the 1.43.0 release. I wonder if we should add some sort of check to the makefile for that.

The action config is pulling in the latest golangci-lint, so that should work fine. And the change mentioned above isn't really in the scope of this PR, just thought I would mention it here in case someone has an old version on their system and runs into a problem because of it.

This change looks good to me.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 25, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 25, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
umarcor pushed a commit to umarcor/cobra that referenced this pull request Dec 7, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
umarcor pushed a commit to umarcor/cobra that referenced this pull request Dec 7, 2021
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
jpmcb
jpmcb approved these changes Dec 7, 2021
@jpmcb jpmcb merged commit ff2c55e into spf13:master Dec 7, 2021
2 checks passed
@jpmcb jpmcb removed the kind/stale label Dec 7, 2021
@jpmcb jpmcb added this to the 1.3.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin For general admin tasks to be done usualy by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants