Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noun aliases #257

Merged
merged 1 commit into from Apr 2, 2016
Merged

Add noun aliases #257

merged 1 commit into from Apr 2, 2016

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Mar 25, 2016

Example:

  • "rc" for replicationcontroller
  • "pods" for "pod".

@sttts sttts mentioned this pull request Mar 25, 2016
Merged
@sttts sttts changed the title WIP: add noun aliases Add noun aliases Mar 25, 2016
@sttts
Copy link
Contributor Author

sttts commented Apr 1, 2016

ptal @eparis

@eparis
Copy link
Collaborator

eparis commented Apr 1, 2016

sry. How about a unit test of some sort? otherwise it LGTM.

@sttts
Copy link
Contributor Author

sttts commented Apr 1, 2016

Good point @ tests. Will add them of course.

@sttts
Copy link
Contributor Author

sttts commented Apr 2, 2016

Here we go. Tests added. ptal.

@eparis eparis merged commit 60267ae into spf13:master Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sttts @eparis